On Thu, Jan 07, 2010 at 10:53:30AM -0600, Anthony Liguori wrote: > On 01/07/2010 10:15 AM, Gleb Natapov wrote: > >>KVM_CPUID_SIGNATURE is unnecessary as a guard because it's always > >>been present in kvm_para.h. Since we include kvm_para.h > >>unconditionally, there's no way we wouldn't have > >>KVM_CPUID_SIGNATURE. > >> > >It is there in qemu-kvm and we suppose to bring knowledge from there :) > > Hopefully just the good bits. > > >But I can drop it if you like. > > I don't want to deviate unnecessarily from qemu-kvm so we can > approach this in one of two ways. We can remove the guard in > qemu-kvm and Avi can send me a pull request with this feature. I > can also just pull in the patch as-is and we can fix this in both > places later. I'm happy either way. > Actually qemu-kvm doesn't uses this function right now. It has it's own version in qemu-kvm-x86.c. The idea was to teach qemu-kvm to use upstream function instead.
-- Gleb.