On 04/21/2014 10:38 PM, Paolo Bonzini wrote:
Il 21/04/2014 19:09, Cole Robinson ha scritto:
I don't see why tpm is disabled by default: it doesn't have any
external dependencies, or change default behavior. Leaving it disabled
is just going to cause it to bit rot.
Enable it by default, and change --enable-tpm to --disable-tpm if
people still want an option to compile it out.
I'm not sure how useful the TPM emulation is mostly useless without
firmware support. Also, not having any option except passthrough
limits the functionality as well.
Since IBM is not developing it anymore as far as I know, perhaps it's
better to rip it out entirely.
That's not true. There is an ongoing effort to support a CUSE based TPM
using the existing passthrough TPM implementation plus some ioctls to
control that external TPM.
Regards,
Stefan
Paolo
Signed-off-by: Cole Robinson <crobi...@redhat.com>
---
configure | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index 69b9f56..45dc100 100755
--- a/configure
+++ b/configure
@@ -320,7 +320,7 @@ virtio_blk_data_plane=""
gtk=""
gtkabi="2.0"
vte=""
-tpm="no"
+tpm="yes"
libssh2=""
vhdx=""
quorum="no"
@@ -1073,7 +1073,7 @@ for opt do
;;
--enable-vte) vte="yes"
;;
- --enable-tpm) tpm="yes"
+ --disable-tpm) tpm="no"
;;
--disable-libssh2) libssh2="no"
;;
@@ -1343,7 +1343,7 @@ Advanced options (experts only):
--disable-glusterfs disable GlusterFS backend
--enable-gcov enable test coverage analysis with gcov
--gcov=GCOV use specified gcov [$gcov_tool]
- --enable-tpm enable TPM support
+ --disable-tpm disable TPM support
--disable-libssh2 disable ssh block device support
--enable-libssh2 enable ssh block device support
--disable-vhdx disables support for the Microsoft VHDX
image format