29.04.2014 12:38, Paolo Bonzini wrote: > Il 29/04/2014 10:26, Christophe Fergeau ha scritto: >>> > Replace QemuMutex with GMutex and QemuCond with GCond >>> > (with corresponding function changes), to make libcacard >>> > independent of qemu internal functions. >>> > >>> > Also replace single instance pstrcpy() in vcard_emul_nss.c >>> > to strncpy(). This reverts commit 2e679780ae86c6ca8. >> An alternative would be to use g_strlcpy which guarantees >> nul-termination. > > Yes, that is better.
Actually in this very place it isn't really important, given we always know the exact length of the source and are able to adjust it to fit into the buffer. With g_strlcat() code becomes a bit more ugly... ;) But mind you, this is the least important change in the whole patchset. We are risking to dig into unimportant details and miss forest for the trees in the result. Thanks, /mjt
