05.05.2014 13:26, Andreas Färber пишет:
>> 03.05.2014 12:38, Michael Tokarev wrote:

>>> +        error_set(errp,
>>> +                  ambiguous ? "Path '%s' is ambiguous" : 
>>> QERR_DEVICE_NOT_FOUND,
>>> +                  path);

>> I've applied this version.
> 
> Please undo. error_set() unlike error_setg() expects an ErrorClass
> argument before the string. QERR_* macro contains *two* comma-separated
> values, so it is on top filling in the device-not-found message as path
> in the ambiguous case.

Heh, I havent tried to compile it yet ;)  Ofcourse I'd find this out before
sending the pull request.  Actually this is a classic ENOCOFFEE, twice.

I'll fix this for real.  This makes way too many iterations.

/mjt


Reply via email to