On Tue, May 6, 2014 at 12:24 AM, Pranavkumar Sawargaonkar <pranavku...@linaro.org> wrote: > Hi Rob, Peter, > > On 5 May 2014 20:13, Peter Maydell <peter.mayd...@linaro.org> wrote: >> On 5 May 2014 15:09, Rob Herring <robherri...@gmail.com> wrote: >>> On Mon, May 5, 2014 at 9:06 AM, Rob Herring <robherri...@gmail.com> wrote: >>>> This does not compile for me: >>>> >>>> CC aarch64-softmmu/hw/arm/virt.o >>>> hw/arm/virt.c: In function ‘create_fdt’: >>>> hw/arm/virt.c:186:44: error: ‘KVM_CAP_ARM_PSCI_0_2’ undeclared (first >>>> use in this function) >>>> if (kvm_check_extension(kvm_state, KVM_CAP_ARM_PSCI_0_2)) { >>>> ^ >>> >>> Note that I am building for system emulation, not KVM which may >>> explain the difference (I assume it actually builds for you). >> > Yes actually it builds for me since i am building KVM. > >> Yes, you can't use the kernel header constants here, you need >> to use the QEMU_ variants that kvm-consts.h provides. > > Sure I will do use QEMU_ variants in next patch so that it builds for > non KVM case also.
We created the psci.h header to be a common header to define the ABI. It has no linux dependency other than that is the master copy ATM. Can we just copy the header to a non-Linux location rather than creating duplicate QEMU_ prefixed defines? Rob