> -----Original Message----- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Friday, May 09, 2014 6:55 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; afaer...@suse.de; m...@redhat.com; > pbonz...@redhat.com; Huangweidong (C); Blue Swirl > Subject: Re: [PATCH] cirrus_vga: adding sanity check for vram size [checkpatch > false positive?] > > Hi, > > > BTW, what's your opinion about isa cirrus vga device, Gerd? > > I'd do the same check there. > But isa_cirrus_vga_realizefn() has no return value for judgment. Adding the isa init function back?
Best regards, -Gonglei
