On 05/08/2014 09:09 AM, Paolo Bonzini wrote: > This series is a prerequisite for improving the SMAP emulation in > qemu-system-x86_64. SMAP is a Broadwell feature and testing it in the > kernel is probably the #1 reason why people are using TCG x86 nowadays. > > In order to implement some of the SMAP checks correctly, I need to define > a new set of ld/st functions, similar to ldl_data but with a different > definition of cpu_mmu_index. This series lets me do that painlessly, > by simplifying the set of macros expected by softmmu_header.h. This is > done by patches 2 to 4. > > In addition, implementation of the MMU lookups are spread across all C > files. There is no reason for this, it can be done in cputlb.c directly. > This is done by patches 5 to 7. > > CPU load/store functions are also split around multiple headers: tcg/tcg.h, > softmmu_header.h, cpu-all.h, exec-all.h. This series consolidates them > all in a single header, cpu_ldst.h, in patches 8 to 11. > > The only reason why this is RFC is that it depends on TCG backends > stopping their use of helper_ld*_mmu and using instead the new > "return-address aware" helpers. With this conversion done, helper_ld*_mmu > are not anymore TCG-related and it makes sense to move them to cpu_ldst.h. > The only backends left to convert are S390, with patches on the list, > and MIPS, which should also get done for 2.1.
Bravo. Patches 2-11: Reviewed-by: Richard Henderson <[email protected]> I'll make sure I get that mips patch set posted this week; I failed to do that before going on holiday last week. r~
