Anthony Liguori wrote: > On 01/14/2010 08:49 AM, Jan Kiszka wrote: >> This fixes eg. "-nographic -serial mon:stdio [-serial ...]". >> > > Is this really an appropriate invocation though? > > -nographic != mon:stdio so the semantics of how this is supposed to > behave is at best ill-defined.
Original -nographic implied mon:stdio unless you specified your own -serial. If this was reasonable or not, changing behavior now breaks tons of scripts. Actually, there is more legacy breakage in the new default handling. The missing translation of "-serial stdio -monitor stdio" => "-serial mon:stdio" can already be harmful to some setups, though I guess they are less common. However, this patch addresses something that is a bug outside the scope of -nographic's semantic. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux
