On Mon, May 19, 2014 at 05:40:36PM +0200, Andreas Färber wrote: > Am 19.05.2014 17:10, schrieb Michael S. Tsirkin: > > On Mon, May 19, 2014 at 02:02:39PM +0200, Alexander Graf wrote: > >> > >> On 19.05.14 10:38, Greg Kurz wrote: > >>> Hi, > >>> > >>> This patch set tries to address comments from the initial > >>> review. For this round, I have focused on two changes: > >>> - as suggested by Andreas, we now call the device specific > >>> code from the generic code to ease the implementation of > >>> future devices. This is achieved with the addition of > >>> load/save methods to VirtioDeviceClass. > >>> - virtio subsections now implement a "needed" concept with > >>> the same semantics as in the VMState code. > >>> > >>> I haven't looked at compat mode issues yet, but it is > >>> on my TODO list. > >> > >> If you fix up the comments to be either > >> > >> /* > >> * foo > >> */ > >> > >> or > >> > >> /* foo */ > >> > >> style, not > >> > >> /* foo > >> */ > >> > >> then you get my > >> > >> > >> Acked-by: Alexander Graf <ag...@suse.de> > >> > >> > >> Alex > > > > Documented anywhere? > > Linux style is > > > > /* Always > > * like this. > > */ > > > > so it's definitely not universal. > > I could've sworn that you (mst) asked at least two people to change > comments from > > /* foo > bar */ > > to > > /* > * foo > */ > > style... > > Andreas
IMHO it's the last */ on the same line as text that looks ugly. /* * foo */ /* foo */ /* foo */ all look ok I think. > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg