> -----Original Message----- > From: qemu-devel-bounces+arei.gonglei=huawei....@nongnu.org > [mailto:qemu-devel-bounces+arei.gonglei=huawei....@nongnu.org] On > Behalf Of Gerd Hoffmann > Sent: Wednesday, May 21, 2014 6:54 PM > To: qemu-devel@nongnu.org > Cc: Gerd Hoffmann; Anthony Liguori > Subject: [Qemu-devel] [PATCH] vnc: refuse to set a password with > VNC_AUTH_NONE > > Current code silently changes the authentication settings > in case you try to set a password without password authentication > turned on. This is bad. Return an error instead. > > If we want allow changing auth settings at runtime this should > be done explicitly using a separate monitor command, not as > side effect of set_passwd. > Agreed. Do you have a plan to do this? Thanks.
> Signed-off-by: Gerd Hoffmann <kra...@redhat.com> > --- > ui/vnc.c | 34 ++++++---------------------------- > 1 file changed, 6 insertions(+), 28 deletions(-) > Reviewed-by: Gonglei <arei.gong...@huawei.com> Best regards, -Gonglei
