On Thu, May 22, 2014 at 03:37:10PM +0800, Fam Zheng wrote: > This makes the SG_IO code of non-dataplane available to dataplane, so that > dataplane can use to allow scsi=on. > > v2: > [1/2] Fix scsi=off case and drop VirtIOBlockReq.scsi. > [2/2] Pass conf to virtio_blk_handle_scsi_req. > > Fam > > > Fam Zheng (2): > virtio-blk: Factor out virtio_blk_handle_scsi_req from > virtio_blk_handle_scsi > dataplane: Support VIRTIO_BLK_T_SCSI_CMD > > hw/block/dataplane/virtio-blk.c | 18 +++++---- > hw/block/virtio-blk.c | 83 > +++++++++++++++++++++++------------------ > include/hw/virtio/virtio-blk.h | 4 ++ > 3 files changed, 60 insertions(+), 45 deletions(-)
I wonder if it's okay to use synchronous bdrv_ioctl() but the existing code already does it. It would be bad to block the thread. Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>