On Wed, May 21, 2014 at 06:28:00PM +0200, Kevin Wolf wrote: > @@ -2270,7 +2270,10 @@ int bdrv_commit(BlockDriverState *bs) > } > > total_sectors = length >> BDRV_SECTOR_BITS; > - buf = g_malloc(COMMIT_BUF_SECTORS * BDRV_SECTOR_SIZE); > + > + /* qemu_try_blockalign() for bs will choose an alignment that works for > + * bs->backing_hd as well, so no need to compare the alignment manually. > */ > + buf = qemu_try_blockalign(bs, COMMIT_BUF_SECTORS * BDRV_SECTOR_SIZE);
Missing ENOMEM error handling?