On Mon, 2014-05-26 at 18:42 +0200, Andreas Färber wrote: > Am 26.05.2014 14:48, schrieb Michael S. Tsirkin: > > On Mon, May 26, 2014 at 03:40:54PM +0300, Marcel Apfelbaum wrote: > >> V1 -> V2: > >> - Rebased on qom-next queue. > >> - Patch 1/4: > >> - Since there are a lot of discussions on the correct > >> way to do the fix, added a FIXME comment to find a better way. > >> - Patch 2/4: > >> - Addressed Michael Roth's comments: > >> - Added output visitor test > >> - Tweaked it as advised > >> - Patch 4/4 > >> - Addressed Andreas Farber's comments: > >> - Renamed machine_state -> ms to conform with the other patches > > In the other one it's "machine" now, but I agree that "ms" is > sufficiently understandable in machine.c. :) > > >> - Solved an issue discovered with make check: > >> - Updated machine->kernel_cmdline to be an empty string > >> if no string was supplied by the user. > >> - All other comments were addressed in the mail thread (I hope...) > > > > > > For series: > > > > Acked-by: Michael S. Tsirkin <m...@redhat.com> > > I have them queued on qom-next, Thanks for handling it so quickly, Marcel
> but giving mdroth a chance to ack/nack > the QAPI bits. I believe all his comments are addressed now, save for > deeper investigations with armbru that I hope can be done as follow-up. > > https://github.com/afaerber/qemu-cpu/commits/qom-next > > Still build-testing on BSD. > > Regards, > Andreas >
