> -----Original Message----- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Tuesday, May 27, 2014 9:35 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: kw...@redhat.com; chenliang (T); peter.crosthwa...@xilinx.com; > Huangweidong (C); aligu...@amazon.com; m...@redhat.com; Luonengjun; > arm...@redhat.com; lcapitul...@redhat.com; qiaonuo...@cn.fujitsu.com; > av1...@comtv.ru; kra...@redhat.com; stefa...@redhat.com; > crobi...@redhat.com; ler...@redhat.com; afaer...@suse.de > Subject: Re: [PATCH 3/8] json-parser: fix two coverity defects > > Il 27/05/2014 03:40, arei.gong...@huawei.com ha scritto: > > t *ctxt, va_list *ap) > > } > > token = NULL; > > } else { > > - token = parser_context_pop_token(ctxt); > > - token = NULL; > > + (void)parser_context_pop_token(ctxt); > > } > > > > return QOBJECT(dict); > > @@ -542,8 +541,7 @@ static QObject *parse_array(JSONParserContext > *ctxt, va_list *ap) > > > > token = NULL; > > } else { > > - token = parser_context_pop_token(ctxt); > > - token = NULL; > > + (void)parser_context_pop_token(ctxt); > > } > > > > return QOBJECT(list); > > You used to have 2 dead stores, now you have 4. :) Please remove all > the token = NULL assignments. > OK, Thanks!
Best regards, -Gonglei
