On Wed, Jan 20, 2010 at 01:09:29PM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" <m...@redhat.com> writes: > > > On Wed, Jan 20, 2010 at 08:26:56AM +0100, Markus Armbruster wrote: > >> Jamie Lokier <ja...@shareable.org> writes: > >> > >> > Michael S. Tsirkin wrote: > >> >> On Mon, Jan 18, 2010 at 11:34:59AM +0100, Markus Armbruster wrote: > >> >> > BDRV_O_RDWR is a flag, just like BDRV_SNAPSHOT. We don't have > >> >> > BDRV_DONT_SNAPSHOT, either. > >> >> > >> >> Well, this just mirros the file access macros: we have RDONLY, WRONLY > >> >> and RDRW. I assume this similarity is just historical? > >> > > >> > To avoid confusion, why don't we just call the flag BDRV_O_WRITABLE. > >> > Then it's obvious what clearing that flag means. > >> > >> Sounds good to me. > > > > Won't it be confused with WRONLY? > > I doubt it. "Writable" implies "write-only" no more than "readable" > implies "read-only".
Yes :) But what I am saying is that the disk is readable as well. -- MST
