On 26 May 2014 08:20, Michael Tokarev <m...@tls.msk.ru> wrote: > From: Le Tan <tamlokv...@gmail.com> > > Replace fprintf(stderr,...) with error_report() in files bsd-user/*. > The trailing "\n"s of the @fmt argument have been removed > because @fmt of error_report() should not contain newline. > > Signed-off-by: Le Tan <tamlokv...@gmail.com> > Signed-off-by: Michael Tokarev <m...@tls.msk.ru>
Was this patch tested? Building on FreeBSD the compiler complains: "warning: implicit declaration of function 'error_report' is invalid in C99" because none of these bsd-user files include a header which gives a prototype for error_report. Also, these are just straightforward reporting of command line errors, and I think that, like the linux-user code, we should handle these in the obvious way by printing to stderr. There's no need to drag in the error-handling framework for this, especially since user-mode doesn't have the "maybe we need to send this to the monitor" issues system emulation does. In short, I think we need to revert this commit (1fba509527beb). thanks -- PMM
