On Sat, May 31, 2014 at 11:33:14PM -0400, Gabriel L. Somlo wrote: > @@ -151,10 +141,21 @@ typedef struct E1000State_st { > uint32_t compat_flags; > } E1000State; > > -#define TYPE_E1000 "e1000" > +typedef struct E1000DeviceClass {
The QOM type is called TYPE_E1000_BASE ("e1000-base"), please name this E1000BaseClass. The reasoning is the same as my previous request for consistent naming. Other QOM class users in hw/ also follow this pattern (type "X", class "XClass").