On Mon, Jun 02, 2014 at 01:31:29PM -0600, Eric Blake wrote: > On 06/02/2014 11:51 AM, mtosa...@redhat.com wrote: > > It is necessary to reset RTC interrupt reinjection backlog if > > guest time is synchronized via a different mechanism, such as > > QGA's guest-set-time command. > > > > Failing to do so causes both corrections to be applied (summed), > > resulting in an incorrect guest time. > > > > Signed-off-by: Marcelo Tosatti <mtosa...@redhat.com> > > > > Index: qemu/hw/timer/mc146818rtc.c > > Still no --- separator between your commit message and the patch body. > Are you using 'git send-email'?
OK, diffstats on every patch. > > Index: qemu/qapi-schema.json > > =================================================================== > > --- qemu.orig/qapi-schema.json > > +++ qemu/qapi-schema.json > > @@ -4722,3 +4722,15 @@ > > 'btn' : 'InputBtnEvent', > > 'rel' : 'InputMoveEvent', > > 'abs' : 'InputMoveEvent' } } > > + > > +## > > +# @: rtc-reset-reinjection > > s/: // to resemble most other commands Several commands have ":". What is the correct syntax and why? > > +# This command will reset RTC's interrupt reinjection backlog. > > s/RTC's/the RTC/ > > > +# Can be used if another mechanism to synchronize guest time > > +# is in effect, for example QEMU guest agents guest-set-time > > s/agents/agent's/ Fixed. > > +# command. > > +# > > +# Since: 2.1 > > +## > > +{ 'command': 'rtc-reset-reinjection' } > > Index: qemu/qmp-commands.hx > > =================================================================== > > --- qemu.orig/qmp-commands.hx > > +++ qemu/qmp-commands.hx > > @@ -3572,3 +3572,26 @@ Example: > > } } ] } > > > > EQMP > > + > > +#if defined (TARGET_I386) > > + { > > + .name = "rtc_reset_reinjection", > > s/rtc_reset_reinjection/rtc-reset-reinjection/ This is a function name.