On 06/04/2014 07:51 AM, Jeff Cody wrote: > This allows a user to make a live change to the backing file recorded in > an open image. > > The image file to modify can be specified 2 ways: > > 1) image filename > 2) image node-name > > Note: this does not cause the backing file itself to be reopened; it > merely changes the backing filename in the image file structure, and > in internal BDS structures. > > It is the responsibility of the user to pass a filename string that > can be resolved when the image chain is reopened, and the filename > string is not validated. > > A good analogy for this command is that it is a live version of > 'qemu-img rebase -u', with respect to changing the backing file string. > > Signed-off-by: Jeff Cody <jc...@redhat.com> > --- > blockdev.c | 102 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > qapi-schema.json | 60 ++++++++++++++++++++++++++++++++ > qmp-commands.hx | 74 ++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 236 insertions(+) >
> +# > +# Method 2 interface > +#--------------------- > +# @image-node-name #optional The name of the block driver state node of the > +# image to modify. The @device argumen is used to s/argumen/argument/ Unless there is any other reason for a respin, I'm hoping the committer can fix the typo, and add: Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature