On 7 June 2014 02:09, Eduardo Habkost <ehabk...@redhat.com> wrote: > On Sat, Jun 07, 2014 at 12:45:26AM +0100, Peter Maydell wrote: >> I'm with Eduardo on this one -- if the user passes us a bad >> command line we should diagnose it helpfully and exit with >> a failure code; abort() is for programming errors. (If nothing >> else, using abort() for user-triggerable conditions tends to >> mean we get bug reports about core dumps, so it's in our >> own interest to not do that :-) ) > > So you are agreeing with Igor, as well. He is just suggesting we keep > terminating QEMU on that case, and we can use exit() for that. My patch, > on the other hand, makes QEMU not terminate on those cases.
No, I'm happy with not terminating and handling the case correctly if that makes more sense for this case; I'm just saying that dumping core is definitely not OK. thanks -- PMM
