On 6 June 2014 14:49, Sean Bruno <sbr...@freebsd.org> wrote: > Add strace support for print_sysarch for all architectures for freebsd. > NetBSD and OpenBSD are not implemented but stubbed out.
In this case you really are implementing a new syscall ("sysarch") and the commit message says it's just strace support! > bsd-user/arm/syscall.h | 36 ++++++++++++++++ > bsd-user/arm/syscall.h.orig | 0 > bsd-user/arm/target_arch_sysarch.h | 78 > ++++++++++++++++++++++++++++++++++ Leave the parts of this that are for architectures we don't have in mainline out for now -- they should be added with the later patchseries which adds support for those archs. > create mode 100644 bsd-user/arm/syscall.h.orig This looks like it's accidentally slipped into your git repo following a merge conflict. There were another couple of .orig files in the list too. It's often a good idea to eyeball the diffstat before sending a patch. > +#define TARGET_HW_MACHINE UNAME_MACHINE > +#define TARGET_HW_MACHINE_ARCH UNAME_MACHINE These look like they ought to be in a different patch. thanks -- PMM