On 06/09/2014 04:25 AM, Hu Tao wrote: > From: Paolo Bonzini <pbonz...@redhat.com> > > This option provides the infrastructure for binding guest NUMA nodes > to host NUMA nodes. For example: > > -object memory-ram,size=1024M,policy=bind,host-nodes=0,id=ram-node0 \ > -numa node,nodeid=0,cpus=0,memdev=ram-node0 \ > -object memory-ram,size=1024M,policy=interleave,host-nodes=1-3,id=ram-node1 \ > -numa node,nodeid=1,cpus=1,memdev=ram-node1 > > The option replaces "-numa node,mem=". > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > Signed-off-by: Hu Tao <hu...@cn.fujitsu.com> > --- > include/sysemu/sysemu.h | 1 +
> +# @mem: #optional memory size of this node; mutually exclusive with @memdev. > +# Equally divide total memory among nodes if both @mem and @memdev are > +# omitted. > +# > +# @memdev: #optional memory backend object. If specified for one node, > +# it must be specified for all nodes. > # > # Since: 2.1 > ## > @@ -4753,4 +4757,5 @@ > 'data': { > '*nodeid': 'uint16', > '*cpus': ['uint16'], > - '*mem': 'size' }} > + '*mem': 'size', > + '*memdev': 'str' }} This looks okay. > diff --git a/qemu-options.hx b/qemu-options.hx > index d3cd2ce..e448d33 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -95,16 +95,20 @@ specifies the maximum number of hotpluggable CPUs. > ETEXI > > DEF("numa", HAS_ARG, QEMU_OPTION_numa, > - "-numa node[,mem=size][,cpus=cpu[-cpu]][,nodeid=node]\n", QEMU_ARCH_ALL) > + "-numa node[,mem=size][,memdev=id][,cpus=cpu[-cpu]][,nodeid=node]\n", > QEMU_ARCH_ALL) But this implies both parameters can be used at once. Is it worth rewriting in two lines: "-numa node[,mem=size][,cpus=cpu[-cpu]][,nodeid=node]\n" "-numa node[,memdev=id][,cpus=cpu[-cpu]][,nodeid=node]\n" to make the exclusion clearer? > -to allocate RAM and vCPUs respectively. > +to allocate RAM and vCPU srespectively, and possibly @option{-object} s/vCPU srespectively/vCPUs respectively/ -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature