On Thu, Jun 12, 2014 at 04:33:11PM +0200, Markus Armbruster wrote: > "Michael S. Tsirkin" <m...@redhat.com> writes: > > > On Thu, Jun 12, 2014 at 10:27:53AM +0200, Markus Armbruster wrote: > >> "Michael S. Tsirkin" <m...@redhat.com> writes: > >> > >> > Names with spaces in them are nasty, let's not go there. > >> > >> Yes, they are, but please use '-' instead of '_'. I can see just a few > >> devices with '_' in their name, but more than a hundred with '-'. > > > > No problem, I made this change. > > Result pushed to the pci branch, pls take a look there. > > > > Thanks! > > The change is good, but I have more questions now. > > What about "ICH9 SMB" in hw/i2c/smbus_ich9.c?
Same thing I guess. I noticed the other one because Igor touched it in his patch. Pls go ahead and submit a patch. > Technically, device names are ABI. These two are onboard devices, so > changing their names can't break -device / device_add use. It still > could break -global use. Do we care? > > If yes, the obvious fix is to keep the old name as alias. I don't think we care practically, but sure, go ahead and submit the patch if you feel like it. -- MST
