On 06/05/2014 08:36 AM, Igor Mammedov wrote: > ... it will be used to abstract generic ACPI bits from > device that implements ACPI interface. > > ACPIOSTInfo type is used for passing-through raw _OST > event/status codes reported by guest OS to a management > layer. It lets management tools to interpret values
s/to //
> as specified by ACPI spec if it interested in it.
s/if it/if it is/
>
> QEMU doesn't encode these values as enum, since it
> doesn't need to handle them and it allows interface
> to scale well without any changes in QEMU while guest
> OS and management evolves in time.
>
> Signed-off-by: Igor Mammedov <imamm...@redhat.com>
> ---
> v2:
> - fix doc comments, describe not described fields
> - add slot-type field with DIMM type for now, which later
> we could extend to PCI slots and probably to CPUs
> - extend commit message describing why source/status
> are raw integers vs enum.
> ---
> hw/acpi/Makefile.objs | 1 +
> hw/acpi/acpi_interface.c | 15 ++++++++++++
> include/hw/acpi/acpi_dev_interface.h | 43
> ++++++++++++++++++++++++++++++++++
> qapi-schema.json | 31 ++++++++++++++++++++++++
> 4 files changed, 90 insertions(+), 0 deletions(-)
> create mode 100644 hw/acpi/acpi_interface.c
> create mode 100644 include/hw/acpi/acpi_dev_interface.h
>
> +## @ACPIOSTInfo
> +#
> +# OSPM Status Indication for a device
> +# For description of possible values of @source and @status fields
> +# see "_OST (OSPM Status Indication)" chapter of ACPI5.0 spec.
> +#
> +# @device: device ID accossiated with slot
s/accossiated/associated/
Missing #optional annotation
> +#
> +# @slot: slot ID, unique per slot of a given @slot-type
> +#
> +# @slot-type: type of the slot
> +#
> +# @source: an integer containing the source event
> +#
> +# @status: an integer containing the status code
> +#
> +# Since: 2.1
> +##
> +{ 'type': 'ACPIOSTInfo',
> + 'data' : { '*device': 'str',
> + 'slot': 'str',
> + 'slot-type': 'ACPISlotType',
> + 'source': 'int',
> + 'status': 'int' } }
>
Fix the docs, and you can add:
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
