On 25.01.2010, at 17:52, Jes Sorensen wrote: > Hi, > > This is the QEMU patch for providing the e820-reserve space through > qemu-cfg.
Howdy. Congratulations to the new mail address - looks neat ;-). Two comments: 1) I don't see how passing a single region is any help. I'd rather like to see a device tree like table structure You'd get one variable for len of the table, one with the contents. So for a universal reserved region specifier you'd get: <u64 base><u64 len> Then have len=2 and put data in the table: <u64 base1><u64 len1><u64 base2><u64 len2> That way we'd get 2 entries and the chance to enhance them later on. In fact, it might even make sense to pass the whole table in such a form. That way qemu generates all of the e820 tables and we can declare whatever we want. Just add a type field in the table. 2) Please inline patches. They showed up as attachments here, making them really hard to comment on. Alex
