On Tue, Jun 17, 2014 at 11:38:16AM -0700, Nishanth Aravamudan wrote: > On 17.06.2014 [11:07:00 -0300], Eduardo Habkost wrote: > <snip> > > > If it is canonical and kosher way of using NUMA in QEMU, ok, we can use > > > it. > > > I just fail to see why we need a requirement for nodes to go consequently > > > here. And it confuses me as a user a bit if I can add "-numa > > > node,nodeid=22" (no memory, no cpus) but do not get to see it in the > > > guest. > > > > I agree with you it is confusing. But before we support that use case, > > we need to make sure auto-allocation is handled properly, because it > > would be hard to fix it later without breaking compatibility. > > > > We probably just need a "present" field on struct NodeInfo, so > > machine-specific code and auto-allocation code can differentiate nodes > > that are not present on the command-line from empty nodes that were > > specified in the command-line. > > What/where is struct NodeInfo?
It was introduced very recently. See the pull request at: From: "Michael S. Tsirkin" <m...@redhat.com> Message-ID: <1403021756-15960-1-git-send-email-...@redhat.com> Subject: [Qemu-devel] [PULL 000/103] pc, pci, virtio, hotplug fixes, enhancements for 2.1 git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream -- Eduardo