On 06/17/2014 03:53 PM, Jeff Cody wrote: > Now that active layer block-commit is supported, the 'top' argument > no longer needs to be mandatory. > > Change it to optional, with the default being the active layer in the > device chain. > > Reviewed-by: Eric Blake <ebl...@redhat.com> > Reviewed-by: Benoit Canet <ben...@irqsave.net> > Signed-off-by: Jeff Cody <jc...@redhat.com> > ---
As mentioned elsewhere, this is the patch that changed from v5. But so
there's no confusion, I've gone back over this one, and my R-b still stands.
> + /* Important Note:
> + * libvirt relies on the DeviceNotFound error class in order to probe
> for
> + * live commit feature versions; for this to work, we must make sure to
> + * perform the device lookup before any generic errors that may occur
> in a
> + * scenario in which all optional arguments are omitted. */
> bs = bdrv_find(device);
> if (!bs) {
> error_set(errp, QERR_DEVICE_NOT_FOUND, device);
Thanks for adding the comment :)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
