Il 18/06/2014 16:57, David Marchand ha scritto:
Hello Stefan,
On 06/18/2014 12:48 PM, Stefan Hajnoczi wrote:
One more thing to add to the list:
static void ivshmem_read(void *opaque, const uint8_t * buf, int flags)
The "flags" argument should be "size". Size should be checked before
accessing buf.
You are welcome to send a fix and I will review it.
This is not what a maintainer should do. A maintainer should, if
possible, contribute fixes to improve the code.
I know this is very different from usual "company-style" development
(even open source software can be developed on with methods more typical
of proprietary software), but we're asking you to do it because you
evidently understand ivshmem better than us.
Claudio has more experience with free/open-source software. Since he's
interested in ivshmem, he can help you too. Perhaps you could try
sending out the patch, and Claudio can review it and send pull requests
at least in the beginning?
Paolo
