On 06/23/2014 03:38 PM, Stefan Hajnoczi wrote:
>
> The return value of bdrv_open() is a negative errno. -1 does not make
> sense in this case.
>
> Please add an int return value to bdrv_append_temp_snapshot() so the
> caller can determine the real errno. Then the remainder of the patch
> can be:
>
> if (snapshot_flags) {
> - bdrv_append_temp_snapshot(bs, snapshot_flags, &local_err);
> + ret = bdrv_append_temp_snapshot(bs, snapshot_flags, &local_err);
> if (local_err) {
> - error_propagate(errp, local_err);
> goto close_and_fail;
> }
> }
>
That's fine to me, I shall send patch v2 for it.
Thanks.
--
Chen Gang
Open share and attitude like air water and life which God blessed
