On 24.06.2014 20:06, Michael Tokarev wrote: > 19.06.2014 17:15, Sergey Fedorov wrote: >> The only use for GPROF_CFLAGS is in main makefile, but this variable put >> only to taget config file which is not included to the main makefile. >> Lets put gprof config variables to host config file. > I'm not sure I follow. > > First of all, GPROF_CFLAGS is referenced in Makefile.objs, not the > main makefile. And Makefile.objs _is_ included by the main Makefile. > > Second, now you're including this variable into 2 places. > > Maybe it is better to stop putting it to the target config file > at the same time? > > What problem you're trying to solve? > > Maybe some more details will help?
I'm sorry. Seems the patch is based on v2.0.0, not current master. So this patch can be ignore. // Sergey > > Thanks, > > /mjt > >> Signed-off-by: Sergey Fedorov <serge.f...@gmail.com> >> --- >> configure | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/configure b/configure >> index dfbe75e..e0433b9 100755 >> --- a/configure >> +++ b/configure >> @@ -4323,6 +4323,10 @@ fi >> if test "$profiler" = "yes" ; then >> echo "CONFIG_PROFILER=y" >> $config_host_mak >> fi >> +if test "$gprof" = "yes" ; then >> + echo "CONFIG_GPROF=y" >> $config_host_mak >> + echo "GPROF_CFLAGS=-p" >> $config_host_mak >> +fi >> if test "$slirp" = "yes" ; then >> echo "CONFIG_SLIRP=y" >> $config_host_mak >> echo "CONFIG_SMBD_COMMAND=\"$smbd\"" >> $config_host_mak >> @@ -5160,7 +5164,7 @@ alpha) >> esac >> >> if test "$gprof" = "yes" ; then >> - echo "TARGET_GPROF=yes" >> $config_target_mak >> + echo "TARGET_GPROF=y" >> $config_target_mak >> if test "$target_linux_user" = "yes" ; then >> cflags="-p $cflags" >> ldflags="-p $ldflags" >>