On 06/25/2014 04:02 AM, Eduardo Habkost wrote: > This series is an attempt to make the compat_props lists from the PC code > reusable by other machine-types. All the compat bits that are on those lists > are > not tied to a specific machine-type, but instead to the device code that was > present on a given QEMU version. > > The last patch is a proposal to simply eliminate the PC-specific compat props > macros, because we don't really need them today. All compat properties we have > can be on global QEMU-version-specific lists, because PC-specific properties > are > not going to affect other machine-types anyway.
The idea is cool, the separation of which properties go to boards.h and which stay in hw/i386/pc_piix.c is not clear though (PIIX is unlikely to be wanted somewhere else but virtio is). > > Eduardo Habkost (4): > q35: Move q35-specific compat macros to pc_q35.c > pc: Eliminate nesting of common PC_COMPAT_* macros > machine: Introduce QEMU_COMPAT_* macros > [RFC] Eliminate PC-specific compat_props > > hw/i386/pc_piix.c | 31 +++++-- > hw/i386/pc_q35.c | 19 +++++ > include/hw/boards.h | 207 +++++++++++++++++++++++++++++++++++++++++++++++ > include/hw/i386/pc.h | 224 > --------------------------------------------------- > 4 files changed, 251 insertions(+), 230 deletions(-) -- Alexey