On 30 June 2014 13:29, Paolo Bonzini <pbonz...@redhat.com> wrote: > Il 30/06/2014 12:57, Gerd Hoffmann ha scritto: >> On Mo, 2014-06-30 at 11:33 +0100, Peter Maydell wrote: >>> In that case is qemu_chr_open_socket_fd() incorrect >>> in marking the socket as nonblocking in the >>> is_listen && is_waitconnect case? > > > It's unnecessary. tcp_chr_accept calls tcp_chr_add_client, which takes care > of that. But it doesn't hurt either.
I think the tcp_chr_accept->tcp_chr_add_client->set_nonblock is marking the new fd returned from accept() as nonblocking. The call in qemu_chr_open_socket_fd() is marking the listening fd as nonblocking. So those are different things... thanks -- PMM
