On Mon, 01 Feb 2010 09:25:27 -0600 Anthony Liguori <anth...@codemonkey.ws> wrote:
> On 02/01/2010 07:34 AM, Ian Molton wrote: > > Add a reconnect option that allows sockets to reconnect (after a > > specified delay) to the specified server. This makes the virtio-rng driver > > useful in production environments where the EGD server may need to be > > restarted. > > > > Signed-off-by: Ian Molton<ian.mol...@collabora.co.uk> > > > > I went back and looked at the last series and found my feedback. I had > suggested that instead of automatically reconnecting, a mechanism should > be added for a user to initiate a reconnect. > > Additionally, we should emit events upon disconnect through QMP (now > that we have that functionality). Should we merge all disconnect events or should we keep them separated? I mean, we currently have VNC_DISCONNECT and will likely have SPICE_DISCONNECT. Maybe we could have a SOCKET_DISCONNECT and have a 'source' member, like: { "event": "SOCKET_DISCONNECT", "data": { "source": "vnc" ... } } I can see two drawbacks: 1. We can't do this for connects, which will make this inconsistent 2. Its "data" member is dependent on the source, which makes this event return a set of different info (say vnc auth types vs. auth types) So, I'd keep them separated.