Am 02.02.2010 22:10, schrieb Luiz Capitulino: > This commit adds the basic definitions for the BLOCK_IO_ERROR > event, but actual event emission will be introduced by the > next commits. > > NOTE: Adding a small reference in QMP/qmp-events.txt, but this > file is wrong and will be replaced by proper documentation shortly. > > Signed-off-by: Luiz Capitulino <lcapitul...@redhat.com> > --- > QMP/qmp-events.txt | 7 +++++++ > monitor.c | 3 +++ > monitor.h | 1 + > 3 files changed, 11 insertions(+), 0 deletions(-) > > diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt > index dc48ccc..7886192 100644 > --- a/QMP/qmp-events.txt > +++ b/QMP/qmp-events.txt > @@ -43,3 +43,10 @@ Data: 'server' and 'client' keys with the same keys as > 'query-vnc'. > > Description: Issued when the VNC session is made active. > Data: 'server' and 'client' keys with the same keys as 'query-vnc'. > + > +7 BLOCK_IO_ERROR > +---------------- > + > +Description: Issued when a disk I/O error occurs > +Data: 'device' (device name), 'action' (action to be taken), > + 'operation' ("read" or "write")
I think we should document what allowed values for action are and what their meaning is. And isn't it actually "action that has been taken"? Kevin