On 7 July 2014 13:40, Michael S. Tsirkin <m...@redhat.com> wrote: > From: Nikolay Nikolaev <n.nikol...@virtualopensystems.com> > > Use qtest-obj-y to get the right library order. CONFIG_POSIX ensures > mingw compilation won't break. > > Signed-off-by: Nikolay Nikolaev <n.nikol...@virtualopensystems.com> > Acked-by: Michael S. Tsirkin <m...@redhat.com> > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> > > MST: whitespace tweak > --- > tests/Makefile | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/tests/Makefile b/tests/Makefile > index 7e53d0d..1fcd633 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -158,7 +158,7 @@ gcov-files-i386-y += hw/usb/hcd-ehci.c > gcov-files-i386-y += hw/usb/hcd-uhci.c > gcov-files-i386-y += hw/usb/dev-hid.c > gcov-files-i386-y += hw/usb/dev-storage.c > -#check-qtest-i386-y += tests/vhost-user-test$(EXESUF) > +check-qtest-i386-$(CONFIG_POSIX) += tests/vhost-user-test$(EXESUF)
This breaks 'make check' on MacOSX -- we're CONFIG_POSIX but the vhost-user-test includes linux/vhost.h, which obviously doesn't exist. You wanted CONFIG_LINUX; I'll send a patch to fix this. thanks -- PMM
