On 07/17/2014 05:06 AM, Pavel Dovgalyuk wrote: > This patch adds support for replay_break monitor command. This command > sets the step (measured in executed instructions) where replay should be > stopped. > > Signed-off-by: Pavel Dovgalyuk <pavel.dovga...@ispras.ru> > --- > hmp-commands.hx | 14 ++++++++++++++ > monitor.c | 15 +++++++++++++++ > qapi-schema.json | 11 +++++++++++ > qmp-commands.hx | 23 +++++++++++++++++++++++ > replay/replay-qmp.c | 13 +++++++++++++ > replay/replay.c | 24 +++++++++++++++++++++++- > replay/replay.h | 2 ++ > 7 files changed, 101 insertions(+), 1 deletions(-) >
> +++ b/qapi-schema.json > @@ -3518,3 +3518,14 @@ > # Since: 2.2 > ## > { 'command': 'replay_info', 'returns': 'ReplayInfo' } > + > +## > +# @replay_break replay-break in QMP > +# > +# Sets breakpoint at the specified step of replaying > +# > +# @step: step where breakpoint should be set > +# > +# Since: 2.2 Is the double space intentional? This is a very high-level description - reading just this definition, I don't know what typical settings are, and whether changing the number to be larger or smaller makes a difference. Might be worth a bit more docs. I hate write-only interfaces - how do I query what the current breakpoint step is? -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature