Re: [Qemu-devel] [PATCH v6 1/5] block: Support Archipelago as a QEMU block backend

[Stefan Hajnoczi]

On Fri, Jun 27, 2014 at 11:24:08AM +0300, Chrysostomos Nanakos wrote:
> +    xseg_set_req_data(s->xseg, req, reqdata);
> +    if (op == ARCHIP_OP_WRITE) {
> +        data = xseg_get_data(s->xseg, req);
> +        if (!data) {
> +            archipelagolog("Cannot get XSEG data\n");
> +            goto err_exit;
> +        }
> +        memcpy(data, aio_cb->buffer + bufidx, count);
> +    }

Can you avoid ->buffer and use iov_to_buf() or qemu_iovec_to_buf()
instead?

pgpUArlULrtp3.pgp
Description: PGP signature