On 28 July 2014 10:49, Stefan Hajnoczi <stefa...@redhat.com> wrote: > On Mon, Jul 28, 2014 at 06:03:45AM +0000, Gonglei (Arei) wrote: >> Hi, >> >> Should be easy to fix though. Does the following help? >> >> (Cc'ing Stefan & Kevin) >> >> --> >> xen_disk: fix possible null-ptr dereference >> >> Signed-off-by: Gonglei <arei.gong...@huawei.com> >> --- >> hw/block/xen_disk.c | 1 + >> 1 file changed, 1 insertion(+) > > This code path can never be reached since protocol is always set to one > of 3 valid values in xen_disk.c.
Maybe g_assert_not_reached(); ? thanks -- PMM
