>>> On 7/29/2014 at 08:45 PM, in message <53d79771.1040...@redhat.com>, Eric >>> Blake <ebl...@redhat.com> wrote: > On 07/29/2014 01:18 AM, Chunyan Liu wrote: > > Add nocow info in 'qemu-img info' output to show whether the file > > currently has NOCOW flag set or not. > > > > Signed-off-by: Chunyan Liu <cy...@suse.com> > > Acked-by: Eric Blake <ebl...@redhat.com> > > Actually, this should be Reviewed-by, not Acked-by. My understanding is > that "Reviewed-by" is stronger (I actually read through the patch, and > looked for possible problems) while "Acked-by" is weaker (a maintainer > stating that the work is taken in on the basis of third-party reviews > without actually reviewing the patch itself).
Thanks for clarification. I corrected it and sent. > > > --- > > Resend for QEMU 2.2. Change json version comment. > > > > block/qapi.c | 25 +++++++++++++++++++++++++ > > qapi/block-core.json | 5 ++++- > > 2 files changed, 29 insertions(+), 1 deletion(-) > > > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > >
