Am 07.02.2010 15:19, schrieb Naphtali Sprei: > This version addresses comments by Kevin Wolf <kw...@redhat.com> to v2 > Also separate commits squashed. > > > Open image file read-only where possible > Upgrade file to read-write during commit, back to read-only after commit > Added option for qemu-img.c bdrv_new_open() to open file as read-only > > qemu-img changes based on patch by Sheng Yang <sh...@linux.intel.com> > > > Signed-off-by: Naphtali Sprei <nsp...@redhat.com>
Looks much better to me now. The only thing I'm still unsure about is what to do with the case where re-opening the image fails completely. Have you tested this case? I have no idea what would happen, probably a segfault somewhere. Kevin
