Gonglei (Arei) writes: > Hi, > >> > Yoda conditions lack readability, and QEMU has a >> > strict compiler configuration for checking a common >> > mistake like "if (dev = NULL)". Make it a written rule. <snip> >> >> I know this is my suggested text, but now that I'm re-reading it, I'd >> recommend s/0/1/ in all three places, since comparison to 0 is one of >> those special cases where '!a' is faster to write than 'a == 0'. >> > Got it.
Should we add explicit examples for: if (x) if (!x) then? -- Alex Bennée
