On Wed, 08/06 10:45, Paolo Bonzini wrote: > Il 06/08/2014 07:35, Fam Zheng ha scritto: > > ifeq ($(CONFIG_VIRTIO),y) > > -obj-y += virtio-scsi.o > > +obj-y += virtio-scsi.o virtio-scsi-dataplane.o > > obj-$(CONFIG_VHOST_SCSI) += vhost-scsi.o > > endif > > I first thought that this must be conditional on > CONFIG_VIRTIO_BLK_DATA_PLANE. However, CONFIG_VIRTIO_BLK_DATA_PLANE is > itself obsolete: > > ########################################## > # adjust virtio-blk-data-plane based on linux-aio > > if test "$virtio_blk_data_plane" = "yes" -a \ > "$linux_aio" != "yes" ; then > error_exit "virtio-blk-data-plane requires Linux AIO, please try > --enable-linux-aio" > elif test -z "$virtio_blk_data_plane" ; then > virtio_blk_data_plane=$linux_aio > fi > > and there's no requirement to have Linux AIO anymore. Can you prepare a > patch to drop CONFIG_VIRTIO_BLK_DATA_PLANE, and replace patch 1 with it? > > We can leave --disable-virtio-blk-data-plane and > --enable-virtio-blk-data-plane > in for a couple of releases. >
Yes. Sounds a good idea. Fam
