> > Yeah, I need to sit down and look at the code more closely... Perhaps a > > cpu_mark_all_dirty() is enough. > > Hi Paolo, > > cpu_clean_all_dirty, you mean? Has the same effect. > > Marcin's patch to add cpu_synchronize_state_always() has the same > effect. > > What do you prefer ?
I'd prefer cpu_clean_all_dirty because you can call it from the APIC load functions. The bug with your patch is due to the APIC and to migration, it's not in the way your patch touches the kvmclock vmstate_change_handler. Paolo
