On Mon, Aug 11, 2014 at 04:45:18PM +0800, Fam Zheng wrote: > diff --git a/tests/qemu-iotests/051.out b/tests/qemu-iotests/051.out > index d7b0f50..f6d9dc1 100644 > --- a/tests/qemu-iotests/051.out > +++ b/tests/qemu-iotests/051.out > @@ -122,7 +122,7 @@ QEMU_PROG: -drive if=virtio: Device 'virtio-blk-pci' > could not be initialized > > Testing: -drive if=scsi > QEMU X.Y.Z monitor - type 'help' for more information > -(qemu) QEMU_PROG: -drive if=scsi: Device needs media, but drive is empty > +(qemu) QEMU_PROG: Device needs media, but drive is empty > QEMU_PROG: Device initialization failed. > QEMU_PROG: Initialization of device lsi53c895a failed >
Have you checked where error_report()'s "location" was set to "-drive if=scsi"? Maybe something similar can be implemented. > @@ -149,13 +149,11 @@ QEMU_PROG: -device ide-hd,drive=disk: Device 'ide-hd' > could not be initialized > Testing: -drive if=none,id=disk -device lsi53c895a -device > scsi-disk,drive=disk > QEMU X.Y.Z monitor - type 'help' for more information > (qemu) QEMU_PROG: -device scsi-disk,drive=disk: Device needs media, but > drive is empty > -QEMU_PROG: -device scsi-disk,drive=disk: Device initialization failed. > QEMU_PROG: -device scsi-disk,drive=disk: Device 'scsi-disk' could not be > initialized > > Testing: -drive if=none,id=disk -device lsi53c895a -device scsi-hd,drive=disk > QEMU X.Y.Z monitor - type 'help' for more information > (qemu) QEMU_PROG: -device scsi-hd,drive=disk: Device needs media, but drive > is empty > -QEMU_PROG: -device scsi-hd,drive=disk: Device initialization failed. > QEMU_PROG: -device scsi-hd,drive=disk: Device 'scsi-hd' could not be > initialized Not a big loss, I found the generic "Device initialization failed" followed by a specific error message pointless. After this patch we only get the specific error message. I'm happy with that.
pgpielmYpMHu8.pgp
Description: PGP signature