On 20 August 2014 06:04, Peter Crosthwaite <peter.crosthwa...@xilinx.com> wrote: > On Wed, Aug 20, 2014 at 5:01 AM, Peter Maydell <peter.mayd...@linaro.org> > wrote: >> I think we need to revert this (commit b0225c2c0d8) until >> both the Xen callsites are fixed and the leak issue is >> dealt with. >> > > Have half a plan on the leak issue. With > object_get_canonical_path_component() being used increasing as a "get > me the already set, name of this object", I think it's better to just > change to API to return const and remove the free burden from all call > sites completely. If call sites really want a fresh copy they can take > one themselves. Patch on list imminently.
I'm going to go ahead and revert this patch for the moment so we can take our time reviewing that patch set. thanks -- PMM
