Am 28.07.2014 um 10:48 hat Hu Tao geschrieben: > ping... > > All the 6 patches have reviewed-by now.
Looks mostly good to me, I have only a few minor comments that wouldn't block inclusion but could be addressed in follow-up patches. However, you have a dependency on a patch series from Max (you use minimal_blob_size()), which hasn't been reviewed and merged yet, so your series is blocked on that. If you want to get your series merged quicker, you could replace this with a rough estimate that excludes the clusters used by refcount table and blocks. If full preallocation isn't really full, but only preallocation of 99.9%, that's probably good enough in practice. Kevin
