On Mon, 2014-08-25 at 07:47 +0000, Gonglei (Arei) wrote: > > -----Original Message----- > > From: Knut Omang [mailto:knut.om...@oracle.com] > > Sent: Sunday, August 24, 2014 9:32 PM > > To: qemu-devel@nongnu.org > > Cc: Michael S. Tsirkin; Alexey Kardashevskiy; Juan Quintela; Marcel > > Apfelbaum; > > Markus Armbruster; Paolo Bonzini; Gonglei (Arei); Igor Mammedov; Knut > > Omang > > Subject: [PATCH v2 3/4] ioh3420: Remove obsoleted, unused ioh3420_init > > function > > > > Signed-off-by: Knut Omang <knut.om...@oracle.com> > > --- > > hw/pci-bridge/ioh3420.c | 24 ------------------------ > > 1 file changed, 24 deletions(-) > > > > diff --git a/hw/pci-bridge/ioh3420.c b/hw/pci-bridge/ioh3420.c > > index aed2bf1..e6674a1 100644 > > --- a/hw/pci-bridge/ioh3420.c > > +++ b/hw/pci-bridge/ioh3420.c > > @@ -157,30 +157,6 @@ static void ioh3420_exitfn(PCIDevice *d) > > pci_bridge_exitfn(d); > > } > > > > -PCIESlot *ioh3420_init(PCIBus *bus, int devfn, bool multifunction, > > - const char *bus_name, pci_map_irq_fn > > map_irq, > > - uint8_t port, uint8_t chassis, uint16_t slot) > > -{ > > - PCIDevice *d; > > - PCIBridge *br; > > - DeviceState *qdev; > > - > > - d = pci_create_multifunction(bus, devfn, multifunction, "ioh3420"); > > - if (!d) { > > - return NULL; > > - } > > - br = PCI_BRIDGE(d); > > - > > - qdev = DEVICE(d); > > - pci_bridge_map_irq(br, bus_name, map_irq); > > - qdev_prop_set_uint8(qdev, "port", port); > > - qdev_prop_set_uint8(qdev, "chassis", chassis); > > - qdev_prop_set_uint16(qdev, "slot", slot); > > - qdev_init_nofail(qdev); > > - > > - return PCIE_SLOT(d); > > -} > > - > > static Property ioh3420_props[] = { > > DEFINE_PROP_BIT(COMPAT_PROP_PCP, PCIDevice, cap_present, > > QEMU_PCIE_SLTCAP_PCP_BITNR, true), > > -- > > 1.9.0 > > That's OK. But the declaration of header file should also be removed. > I noticed MST have pulled into master tree. So, maybe I can post > another patch to fix this trivial problem.
Yes, definitely, an obvious mistake from me, sorry. Don't understand how I could have overlooked that.. Knut > Best regards, > -Gonglei
