On Tue, Aug 26, 2014 at 12:04:27PM +0530, Aravinda Prasad wrote: > > > On Tuesday 26 August 2014 11:08 AM, David Gibson wrote: > > On Mon, Aug 25, 2014 at 07:15:16PM +0530, Aravinda Prasad wrote: > >> Extend rtas-blob to accommodate error log. Error log > >> structure is saved in rtas space upon a machine check > >> exception. > > > > Hrm. Putting the reserved space into the actual firmware image file > > seems really clumsy to me. Wouldn't it be better to reserve the space > > directly from qemu, then just paste the 20 bytes of code into that > > area. > > Hmm. It is possible to it from qemu. In that case we can get rid of > spapr-rtas.S. Let me think about that.
I think getting rid of spapr-rtas.S is probably a good idea. It
complicates building things for the sake of 5 instructions.
Especially since in your new code you construct the vector
instructions directly, it makes sense to do the same thing for
spapr-rtas.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
pgpN2VWB8lSiQ.pgp
Description: PGP signature
