On Tue, 08/26 14:21, Stefan Hajnoczi wrote: > On Thu, Jun 05, 2014 at 04:47:43PM +0800, Fam Zheng wrote: > > diff --git a/scripts/qtest b/scripts/qtest > > deleted file mode 100755 > > index 4ef6c1c..0000000 > > --- a/scripts/qtest > > +++ /dev/null > > @@ -1,5 +0,0 @@ > > -#!/bin/sh > > - > > -export QTEST_QEMU_BINARY=$1 > > -shift > > -"$@" > > Why delete this? The script is unrelated to qtest.py. > > I think nothing uses scripts/qtest so it could be deleted in a separate > commit if you feel that is worthwhile.
OK. I'll send a separate patch. > > > +import errno > > +import socket > > + > > +class QEMUQtestProtocol: > > Using new-style classes is probably a good idea: > > class QEMUQtestProtocol(object): > > https://docs.python.org/2.7/reference/datamodel.html#newstyle OK.
