On 08/27/2014 07:29 AM, Stefan Hajnoczi wrote: > Name the 'granularity' parameter and give its expected value range. > Previously the device name was mistakingly reported as the parameter
s/mistakingly/mistakenly/ > name. > > Note that the error class is unchanged from ERROR_CLASS_GENERIC_ERROR. > > Reported-by: Eric Blake <ebl...@redhat.com> > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > --- > blockdev.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) buf-size has the same bug a few lines later; might as well fix both at once. But what you have is a strict improvement, so depending on whether you do a v2 to fix buf-size, vs. do a followup patch, you could add: Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
